Posting invalid batches with wrong family name and address # Sprint 18#49
Open
shresthichauhan wants to merge 3 commits intolntdev:rest_api_testingfrom
Open
Posting invalid batches with wrong family name and address # Sprint 18#49shresthichauhan wants to merge 3 commits intolntdev:rest_api_testingfrom
shresthichauhan wants to merge 3 commits intolntdev:rest_api_testingfrom
Conversation
Contains base class for all test classes Contains conftest.py for pytest cli and session fixtures Contains utils.py for utility methods required in calling rest api endpoints and other functions for testing the endpoints Contains Test files inside test folders for rest api testing Includes thread module for various threads for multi validator testing Includes ssh, payload and workload modules for performing ssh, creating payload and generating workload using threads Signed-off-by: aditya singh <adityasingh27@hotmail.com>
Signed-off-by: shresthichauhan <shresthix.chauhan@intel.com>
Signed-off-by: shresthichauhan <shresthix.chauhan@intel.com>
asing177
requested changes
Aug 29, 2018
|
|
||
|
|
||
| def make_intkey_bad_address(name): | ||
| return INTKEY_ADDRESS_PREFIX + hashlib.sha512( |
Collaborator
There was a problem hiding this comment.
Can there be an another way to create bad address , apart from this ?
Like prefix is incorrect etc ...
This one seems to return a shortened address
| payload = IntKeyPayload( | ||
| verb=verb,name=name,value=1) | ||
|
|
||
| addr = make_intkey_bad_address(name) |
Collaborator
There was a problem hiding this comment.
There is a need to generalize these methods now ..or they will keep on mounting lines of code....already about to cross 5000 locs
|
|
||
| for txn in txns: | ||
| data = MessageToDict( | ||
| txn, |
Collaborator
There was a problem hiding this comment.
Test cases seem fine ....but we can improve on the structure.
lntdev
force-pushed
the
rest_api_testing
branch
from
83f6621 to
1930319
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shresthichauhan shresthix.chauhan@intel.com